Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export LLMSession and SyncSession #66

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

abetlen
Copy link
Contributor

@abetlen abetlen commented May 19, 2023

Hi @slundberg and all, first off great work on this project, I'm very excited to see how it develops.

As per #58 it would be very useful to be able to extend guidance to support additional LLM models to make use of all of the features like token healing and regex sampling.

I understand this project is quite new and you probably want to avoid the cost of maintaining N implementations. If it's an acceptable solution, can we export LLMSession and SyncSession so external projects can add support on their own?

…r additional models

Hi @slundberg and all, first off great work on this project, I'm very excited to see how it develops.

As per guidance-ai#58 it would be very useful to be able to extend guidance to support additional LLM models and make use of all of the features.

I understand this project is quite new and you probably want to avoid the cost of maintaining N implementations. If it's an acceptable solution, can we export `LLMSession` and `SyncSession` so external projects can add support on their own?
@abetlen
Copy link
Contributor Author

abetlen commented May 22, 2023

@microsoft-github-policy-service agree

@slundberg
Copy link
Collaborator

slundberg commented May 25, 2023

Thanks! And sorry to be slow here.

Exporting seems like a good plan. The only catch is that I am not sure the LLMSession API is perfectly frozen yet, but we can also version check later if needed. I'll merge now (just note that #123 might change some parts of the API depending on how it lands).

@slundberg slundberg merged commit e455fe6 into guidance-ai:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants