Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only depend on tomli on Python < 3.11 #72

Merged

Conversation

mkniewallner
Copy link
Contributor

Since Python >= 3.11 includes tomllib with an API that is identical to tomli (see
https://github.com/hukkin/tomli?tab=readme-ov-file#building-a-tomlitomllib-compatibility-layer), we can conditionally require tomli on Python < 3.11 only.

Since Python >= 3.11 includes `tomllib` with an API that is identical to
`tomli` (see
https://github.com/hukkin/tomli?tab=readme-ov-file#building-a-tomlitomllib-compatibility-layer),
we can conditionally require `tomli` on Python < 3.11 only.
@mkniewallner mkniewallner marked this pull request as ready for review July 16, 2024 23:41
@guilatrova guilatrova added the good first issue Good for newcomers label Aug 5, 2024
@guilatrova
Copy link
Owner

Sorry about the delay. I'm merging it now but it will be deployed later this week.

Thanks for following all the guidelines.

@guilatrova guilatrova merged commit f218942 into guilatrova:main Aug 5, 2024
8 checks passed
@mkniewallner mkniewallner deleted the chore/avoid-tomli-dependency-3.11 branch August 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants