Add BaseException to raise-vanilla-class rule (TRY002)
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epenet
changed the title
BaseException to raise-vanilla-class rule (TRY002)BaseException to raise-vanilla-class rule (TRY002)
|
This makes sense to me, but we need tests to ensure this is covered. If you can't, I'll do it later over the week. |
|
Your commits are also not compliant with our guidelines (to ensure deployments will be triggered properly). |
Thanks for taking charge of this - I'm not sure when I would get a chance to adjust the PR. FYI: the corresponding PR in ruff has been accepted and merged. astral-sh/ruff#12620 |
|
Done in d2a6beb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73