Allow using custom ports in endpoints without using testing=True, as discussed in #55
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s discussed in #55: - Remove the check for custom port in endpoint uri validation. - Validate the `issuer` and/or url values before doing any HTTP request in `OAuth2Client.from_discovery_endpoint()`, unless `testing=True` is used. - if `testing=True`, don't try to validate the `jwks_uri` in `OAuth2Client.from_discovery_document()`
guillp
changed the title
testing=True, as discussed in #55: - Remove the check for custom port in endpoint uri validation. - Validate the issuer and/or url values before doing any HTTP request in OAuth2Client.from_discovery_endpoint(), unless testing=True is used. - if testing=True, don't try to validate the jwks_uri in OAuth2Client.from_discovery_document()testing=True, as discussed in #55
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1683 1688 +5
=========================================
+ Hits 1683 1688 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issuerand/or url values before doing any HTTP request inOAuth2Client.from_discovery_endpoint(), unlesstesting=Trueis used.testing=True, don't try to validate thejwks_uriinOAuth2Client.from_discovery_document()