Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dep with go modules #37

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Replace dep with go modules #37

wants to merge 4 commits into from

Conversation

condemil
Copy link

@condemil condemil commented Oct 7, 2019

A similar PR may already be submitted!
Please search among the pull requests before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

For more information, see the CONTRIBUTING guide.

Summary

This PR fixes/implements the following bugs/features

  • Replace dep with go modules

Closing issues

Fixes #35

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you fmt your code locally prior to submission (orbit run fmt)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (orbit run ci)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files           7        7           
  Lines         254      254           
=======================================
  Hits          240      240           
  Misses          7        7           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7314053...b337dfc. Read the comment docs.

@gulien
Copy link
Owner

gulien commented Oct 8, 2019

Hello @condemil

Thank you for this PR.

You should also update the Golang version in .travis.yml, appveyor.yml and .github/CONTRIBUTING.md to 1.13. In the go.mod file, also add go 1.13 👍

Also, you should update the fmt task by adding go mod tiny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would it be worth migrating to go modules instead of dep?
2 participants