Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node 6 #195

Merged
merged 1 commit into from
May 9, 2019
Merged

Require Node 6 #195

merged 1 commit into from
May 9, 2019

Conversation

demurgos
Copy link
Member

@demurgos demurgos commented May 9, 2019

This commit updates the minimum version supported by gulp-pug to Node 8.
This is aligns with the policy of this library to support active LTS and current versions of Node.

This update is also required to update the dependencies through2 (requires Node 6) and tap (requires Node 8).

@phated
Copy link
Member

phated commented May 9, 2019

I've usually fought for keeping older versions but it's becoming harder and harder to make the case for it (especially now that I run node 10 for Stream.pipeline)

@demurgos
Copy link
Member Author

demurgos commented May 9, 2019

Thanks for commenting.
I'm aware of the policy for core Gulp packages, but generally I'm more flexible for plugins. In this case, this update was prompted by third-party dependencies dropping support: I'm planning to update the dependencies and check the open issues, but got CI errors on older versions.

@phated
Copy link
Member

phated commented May 9, 2019

@demurgos It might be worth revisiting the testing setup because it uses extremely outdated patterns and we could switch to something like Jest. As for through2, the only change in their major bump was bumping readable-stream, which supports node 6. Maybe we should keep that one around since it just stopped being LTS?

@demurgos
Copy link
Member Author

demurgos commented May 9, 2019

Okay, I'll update to require Node 6 then. It means that we need to stay on tap@12 or change the testing framework.
I use Mocha for my own projects (and some tap) so I am not very familiar with Jest. I believe Gulp core uses Mocha so I was more inclined to use it but I could take a look at Jest if you prefer.

@demurgos demurgos mentioned this pull request May 9, 2019
This commit updates the minimum version supported by `gulp-pug` to Node 8.
This is aligns with the policy of this library to support active LTS and current versions of Node.

This update is also required to update the dependency `through2` (requires Node 6).
@demurgos demurgos changed the title Require Node 8 Require Node 6 May 9, 2019
@demurgos
Copy link
Member Author

demurgos commented May 9, 2019

I'm merging once CI passes. See #196 for test framework updates.

@demurgos demurgos merged commit 442acf5 into master May 9, 2019
@demurgos demurgos deleted the node-8 branch May 9, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants