-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add streaming support using vinyl-contents #200
Conversation
Note that putting this into a pipeline converts from streaming contents to buffered contents, which might be bad for some people but it's better than just crashing on streaming contents. |
Ref #198 |
Thank you for the PR. I'll have to take a closer look at how it works but it seems good. |
@demurgos Just wanted to follow up here. I'm currently in the process of abstracting this logic into a utility module but ran into some weird edge cases that I'm not sure how to solve. I'm also starting a new job this week and have been overwhelmed with that. I hope to get back to this soon. |
Okay, thanks for the info. There is no rush. Good luck with your new job 👍 |
Thanks! I had a chance to create a reproduction and submit it to cloneable-readable at mcollina/cloneable-readable#18 |
@demurgos alright, I was finally able to wrap up the This is the first module where I'm trying this approach so we'll need to keep an eye on it before implementing it for other modules. |
@demurgos here is a really quick implementation (with only 1 test) of adding streaming support. Going forward, I think this pattern is going to be the recommended pattern to support streaming in plugins that wrap a module that doesn't support streaming.
I didn't want to try to redo everything since I know you are working on the test updates and I'll have to rebase this when completed.
Closes #198