Fix: Handle non-functions passed as callback

gulpjs · Jun 27, 2016 · cc8bff5 · cc8bff5
1 parent b6b06be
commit cc8bff5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/helpers.js b/lib/helpers.js
@@ -11,7 +11,9 @@ function getExtensions(lastArg) {
 }
 
 function buildOnSettled(done) {
-  done = done || _.noop;
+  if (typeof done !== 'function') {
+    done = _.noop;
+  }
 
   function onSettled(error, result) {
     if (error) {

diff --git a/test/onSettled.js b/test/onSettled.js
@@ -34,4 +34,9 @@ describe('onSettled', function() {
     onSettled()(null, errors);
     done();
   });
+
+  it('should handle non-functions as callbacks', function(done) {
+    onSettled('not a function')(null, errors);
+    done();
+  });
 });