Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force and forbid respawning #7

Closed
wants to merge 4 commits into from

Conversation

sttk
Copy link
Contributor

@sttk sttk commented Dec 9, 2017

This pr enables to forbid respawning with --no-respawning cli flag, and enables to respawn with specified node flags.

This pr will help to solve js-liftoff's issue #89, gulp-cli's issue #109 comment, and issue #4.

@sttk sttk force-pushed the force-and-forbid-respawning branch from cd8ce1e to 3df3f30 Compare December 10, 2017 05:25
@sttk
Copy link
Contributor Author

sttk commented Dec 10, 2017

I'm sorry but there is a problem that mocha return exit code 0 in spite of error. This cause is seemed to be in my test code. Please wait.

@sttk sttk force-pushed the force-and-forbid-respawning branch from 3df3f30 to 5e3d824 Compare December 10, 2017 14:06
@sttk
Copy link
Contributor Author

sttk commented Dec 10, 2017

The cause of the problem above is original two test cases which execute flaggedRespawn so that respawn is needed.
I created the pr #9 for this problem, and rebased this pr on #6, #9 and #8 clearly.

@phated
Copy link
Member

phated commented Dec 16, 2017

Cherry-picked and amended as 7ca3486

@sttk this series of PRs have been amazing and I'm glad we're moving to a solution on this stuff. Thanks so much!!

@phated phated closed this Dec 16, 2017
@sttk
Copy link
Contributor Author

sttk commented Dec 17, 2017

Thank you for merging! I'm glad, too.

@sttk sttk deleted the force-and-forbid-respawning branch December 17, 2017 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants