Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Chokidar from 2.0.0 to 3.0.0 #41

Closed
wants to merge 1 commit into from
Closed

Upgrade Chokidar from 2.0.0 to 3.0.0 #41

wants to merge 1 commit into from

Conversation

ehmicky
Copy link

@ehmicky ehmicky commented May 1, 2019

Chokidar 3.0.0 is mostly a big refactoring with several bug fixes.

@phated
Copy link
Member

phated commented May 1, 2019

It drops support for our support matrix. This would be a breaking change for us.

@phated phated closed this May 1, 2019
@ehmicky
Copy link
Author

ehmicky commented May 1, 2019

Oh I see.

Why is Gulp supporting Node.js down to 0.10? Node.js itself does not support anything below 8.

This has the side effect of not updating any dependencies (since most libraries support only >=6 or >=8). So glob-watcher can't get the bug fixes and security fixes from new releases. For example if one dependency was to have a security vulnerability issue, the fix could not be used in glob-watcher without breaking the Node.js 0.10 support.

@ehmicky ehmicky deleted the feature/chokidar-v3 branch May 1, 2019 10:46
@phated
Copy link
Member

phated commented May 1, 2019

Because gulp 4 was in development before iojs even happened and a not insignificant amount of users are stuck on node 0.10

We take security notices very seriously, and even take on dependencies in our chain so we can maintain our support matrix. Gulp is a development tool so many security alerts don't affect it the way they would in production/server environments.

@ehmicky
Copy link
Author

ehmicky commented May 1, 2019

Just out of curiosity, how do you keep track of Gulp users Node.js versions?

For reference, last year's Node.js downloads by version:

downloads-by-version

@phated
Copy link
Member

phated commented May 1, 2019

I have notifications set for all sorts of projects that indicate the level of node 0.10/0.12 users, especially when those projects accidentally break those users within their semver range.

@ehmicky
Copy link
Author

ehmicky commented May 1, 2019

Where do you get this data from? I am curious because I would like to know for my own projects (and I don't want to make analytics HTTP requests, for privacy reasons).

The npm API is undocumented, but even then I am not sure it gives out this information (does it?).

Edit: oh I guess maybe you are checking dependent packages (which is given by npm API), then looking up their engines.node package.json field?

@phated
Copy link
Member

phated commented May 1, 2019

I'm not sure what information npm collects or provides but one indicator I use is issues on popular stream modules. In one instance, through2 accidentally broke old node support without a major bump and users created/commented on an issue about it.

@ehmicky
Copy link
Author

ehmicky commented May 1, 2019

Yes exactly that was my guess: through GitHub issues. But that's not so representative as it emphasizes outliers. Namely if you have 10 users on an old Node.js version, you will hear from them, but not from the 10000 users that are on newer versions.

I just wished npm provided with a more accurate way to check this information for library authors.

@simison

This comment has been minimized.

@phated
Copy link
Member

phated commented May 16, 2019

@simison no, that's not how semver works. You have to bump whole major version for breaking changes.

@gulpjs gulpjs locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants