POC: Fallback to graceful-fs@4 if graceful-fs@3 is unsupported #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a vinyl-fs@0.3 version coupled with graceful-fs@4 as a fallback for the regular combination of vinyl-fs@0.3 and graceful-fs@3, so that gulp@3 doesn't break on newer Node.js versions where graceful-fs@3 is unsupported. Current setups and Node.js versions (6.x and below) are not affected.
MylesBorins
force-pushed
the
vinyl-fs-shim
branch
from
37cc44b to
138a824
Compare
|
I think this is the wrong approach. I know you want to attempt to handle this transparently but it would change the semantics of the runtime without any way to know. Let's continue discussion but I'm going to close so it doesn't accidentally get merged. |
|
@phated would you be open to a cli flag?
|
|
Not really. We don't support forcing certain flags (yet) which makes that clumsy to use. So far I like the separate module idea but I need to think on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a vinyl-fs@0.3 version coupled with graceful-fs@4 as a
fallback for the regular combination of vinyl-fs@0.3 and graceful-fs@3,
so that gulp@3 doesn't break on newer Node.js versions where
graceful-fs@3 is unsupported.
Current setups and Node.js versions (6.x and below) are not affected.
Alternative approach to #1760