Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Define configFiles with an array to prioritize configs #133

Merged
merged 6 commits into from
Mar 16, 2024

Conversation

phated
Copy link
Member

@phated phated commented Mar 16, 2024

This reworks the configFiles property to be defined as an array instead of an object. This makes it more verbose to specify multiple configFile lookups. The reason for this change is to have a defined ordering so the config overrides are applied in a guaranteed order.

This has another benefit in that we'll attempt to locate and read all configFiles and the users can do whatever they want with them.

Still TODO:

  • Update docs
  • Write tests for loading all of the config files

@phated phated requested a review from sttk March 16, 2024 04:36
@phated
Copy link
Member Author

phated commented Mar 16, 2024

@sttk I'm going to merge this so I can make the release. Let me know if you notice anything and we can fix in another PR.

@phated phated merged commit 55123fc into main Mar 16, 2024
15 checks passed
@phated phated deleted the phated/config-files-array branch March 16, 2024 22:53
@github-actions github-actions bot mentioned this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant