fix!: Avoid modifying arguments #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine to me - sorry that we were modifying the input object in the first place! |
yocontra
approved these changes
May 23, 2022
|
Even if this was bad, we need to treat it as a breaking fix because people might be relying on the inappropriate behavior If we're doing a breaking release, we'll also want to upgrade the repo scaffold. |
phated
approved these changes
Jul 1, 2022
phated
reviewed
Jul 1, 2022
|
Thanks @fasttime 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, plugin-error modifies the arguments provided to it (errors or option objects) by adding a
pluginproperty and sometimes aerrorormessageproperty to them. This is inconvenient because sometimes you would like to reuse an argument later without having it modified after the first usage of plugin-error.This PR changes the current behavior by ensuring that the argument interpreted as an options object is shallow-cloned before any additional properties are set.