Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash dependecies #77

Merged
merged 3 commits into from
Feb 26, 2017
Merged

Remove lodash dependecies #77

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37526dd
remove lodash defaults and reduce and replace with similar dependencies
AlexHenkel Feb 25, 2017
344cbfa
change map and flatten functions to replace lodash
AlexHenkel Feb 25, 2017
51a3fa1
change collection-map for arr-map
AlexHenkel Feb 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/helpers/buildTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var map = require('lodash.map');
var map = require('collection-map');

var metadata = require('./metadata');

Expand Down
4 changes: 2 additions & 2 deletions lib/helpers/normalizeArgs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

var assert = require('assert');

var map = require('lodash.map');
var flatten = require('lodash.flatten');
var map = require('collection-map');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be arr-map. It's fine adding the extra dependency because it should be deduped with collection-map

var flatten = require('arr-flatten');

function normalizeArgs(registry, args) {
function getFunction(task) {
Expand Down
2 changes: 1 addition & 1 deletion lib/registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

var reduce = require('lodash.reduce');
var reduce = require('object.reduce');

var validateRegistry = require('./helpers/validateRegistry');

Expand Down
4 changes: 2 additions & 2 deletions lib/tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

var defaults = require('lodash.defaults');
var map = require('lodash.map');
var defaults = require('object.defaults');
var map = require('collection-map');

var metadata = require('./helpers/metadata');

Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
"coveralls": "npm run cover && istanbul-coveralls"
},
"dependencies": {
"arr-flatten": "^1.0.1",
"bach": "^1.0.0",
"collection-map": "^0.1.0",
"es6-weak-map": "^2.0.1",
"last-run": "^1.1.0",
"lodash.defaults": "^4.0.1",
"lodash.flatten": "^4.0.0",
"lodash.map": "^4.1.0",
"lodash.reduce": "^4.1.0",
"object.defaults": "^0.3.0",
"object.reduce": "^0.1.7",
"undertaker-registry": "^1.0.0"
},
"devDependencies": {
Expand Down