Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntersectingLine line is failing with TangentArc #324

Closed
gumyr opened this issue Sep 20, 2023 · 0 comments · Fixed by #425
Closed

IntersectingLine line is failing with TangentArc #324

gumyr opened this issue Sep 20, 2023 · 0 comments · Fixed by #425
Assignees
@jdegenstein
Labels
bug Something isn't working
Milestone
Gating Release 1.0.0

Comments

@gumyr
Copy link
Owner

gumyr commented Sep 20, 2023 

with BuildLine() as l:
    l1 = TangentArc((0, 60), (25, 50), tangent=(1, 0))
    IntersectingLine((19, 0), (0, 1), other=l1)

image

For some reason the intersection point isn't calculated correctly.
@gumyr gumyr added the bug Something isn't working label Sep 20, 2023
@gumyr gumyr added this to the Release 1.0.0 milestone Sep 20, 2023
@jdegenstein jdegenstein self-assigned this Dec 7, 2023
@jdegenstein jdegenstein mentioned this issue Dec 7, 2023
Merged
jdegenstein added a commit that referenced this issue Dec 7, 2023
@jdegenstein
Merge pull request #425 from jdegenstein/fix_edge_intersections
0bdaabb 
Update topology.py to fix Edge.intersections edge length issue #324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdegenstein jdegenstein

Labels
bug Something isn't working
Projects
None yet
Milestone
Gating Release 1.0.0
Development

Successfully merging a pull request may close this issue.

Update topology.py to fix Edge.intersections edge length issue #324 jdegenstein/build123d
2 participants
@jdegenstein @gumyr