Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep return not cleaned inside context #451

Open
MatthiasJ1 opened this issue Jan 4, 2024 · 1 comment
Open

Sweep return not cleaned inside context #451

MatthiasJ1 opened this issue Jan 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@MatthiasJ1
Copy link
Contributor

Because of

    if context is not None:
        context._add_to_context(*(new_solids + new_faces), clean=clean, mode=mode)
    elif clean:
        new_solids = [solid.clean() for solid in new_solids]
        new_faces = [face.clean() for face in new_faces]

ret will not be cleaned

with BuildPart():
  ...
  ret = sweep()
@gumyr gumyr added the bug Something isn't working label Jan 5, 2024
@gumyr gumyr added this to the Release 1.0.0 milestone Jan 5, 2024
gumyr added a commit that referenced this issue Jun 12, 2024
@gumyr
Copy link
Owner

gumyr commented Jun 12, 2024

When looking at this issue I discovered that sweeping multiple faces wasn't working properly so that is fixed now.

However, with respect to the issue raised here I'm not sure what the correct answer is. For clean to work, multiple sweep results would have to be fused together which may not be what the user intended and may result in unnecessary OCCT failures. clean is passed to the builder which is explicitly combining parts together and applying clean at the end of the operation not on the parts which are going to be combined (i.e. clean is applied after not before).

I agree though that the use of clean here is very ambiguous and at least needs to be clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants