Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent intersection results for same shape based on method of creation #519

Closed
MatthiasJ1 opened this issue Feb 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@MatthiasJ1
Copy link
Contributor

r = (ShapeList() + (PolarLocations(1, 4) * Line((0,-1),(0,1)))).edges()
l = Line(1,2).edge()
i = l.intersect(*r)
a
r = Rectangle(2,2).edges()
l = (Pos(1) * Line(0,1)).edge()
i = l.intersect(*r)
b
@gumyr gumyr added this to the Gating Release 1.0.0 milestone Feb 1, 2024
@gumyr
Copy link
Owner

gumyr commented Feb 1, 2024

Related to Issue #328

@gumyr gumyr added the bug Something isn't working label Feb 4, 2024
@bernhard-42
Copy link
Collaborator

I think the issue is that after OCCT found the right intersection, the filter in Edge.intersections does a exact comparison instead of taking the tolerance again into account.

I think the following change should be applied:

image

@gumyr
Copy link
Owner

gumyr commented Feb 22, 2024

Thanks @MatthiasJ1 and @bernhard-42, tolerance was indeed the problem, fixed now.

@gumyr gumyr closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants