Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use optimal=False in bounding_box size calculations where applicable #705

Closed
jdegenstein opened this issue Sep 19, 2024 · 0 comments · Fixed by #733
Closed

Use optimal=False in bounding_box size calculations where applicable #705

jdegenstein opened this issue Sep 19, 2024 · 0 comments · Fixed by #733

Comments

@jdegenstein
Copy link
Collaborator

In several places in the codebase bounding_box().diagonal is used to calculate the max object size. Worth investigating if these occurrences can be replaced by bounding_box(optimal=False).diagonal to improve performance as this can be computationally intensive otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove mesh from bounding_box and implement optimal=False in a few more places jdegenstein/build123d
1 participant
@jdegenstein