Remove mesh from bounding_box and implement optimal=False in a few more places
#733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should improve performance of optimal=False, oriented=False
jdegenstein
changed the title
bounding_box(optimal=False... and implemented across the codebasebounding_box and implement across the codebase
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #733 +/- ##
==========================================
+ Coverage 95.98% 96.00% +0.01%
==========================================
Files 25 25
Lines 8346 8351 +5
==========================================
+ Hits 8011 8017 +6
+ Misses 335 334 -1 ☔ View full report in Codecov by Sentry. |
|
Thanks to @bernhard-42 for his contributions to this. |
jdegenstein
changed the title
bounding_box and implement across the codebasebounding_box and implement optimal=False in a few more places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705 in a few places that will improve performance and not impact stability