Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionLine offset alters dimensions #717

Closed
tshead opened this issue Sep 27, 2024 · 2 comments
Closed

ExtensionLine offset alters dimensions #717

tshead opened this issue Sep 27, 2024 · 2 comments

Comments

@tshead
Copy link

tshead commented Sep 27, 2024

The following example creates an arc, then dimensions it twice with ExtensionLine - once “above” the arc, and once “below”.

Expected behavior: both dimensions should be identical.

Actual behavior: the dimensions are different. The dimension “outside” the arc is longer than the dimension “inside” the arc, making it seem that ExtensionLine is displaying the length of the actual dimension line, rather than the length of the target path.

Python 3.12.2 and build123d 0.7.0.

from build123d import *

draft = Draft()

with BuildSketch() as sketch:
    with BuildLine() as line:
        RadiusArc(start_point=(0, 0, 0), end_point=(100, 0, 0), radius=120)
    trace(line_width=1)
    
    ExtensionLine(border=line.edges()[0], offset=-10, draft=draft)
    ExtensionLine(border=line.edges()[0], offset=10, draft=draft)

sketch

image

gumyr added a commit that referenced this issue Oct 4, 2024
@gumyr
Copy link
Owner

gumyr commented Oct 4, 2024

Thanks for pointing this out. I didn't think to test length measurement of an arc.
image

@gumyr gumyr closed this as completed Oct 4, 2024
@tshead
Copy link
Author

tshead commented Oct 4, 2024

@gumyr: nice to have a quick response, thanks. I’ve never actually needed an arc length dimension, but I stumbled on this while experimenting with the various dimension-related APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants