Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotation ordering to Location, Rotation, and Plane.rotated #420

Merged
merged 14 commits into from
Dec 5, 2023

Conversation

jdegenstein
Copy link
Collaborator

This PR adds rotation ordering to Location, Rotation, and Plane.rotated. I also changed Rotation to allow more input types.

I am looking for input on if _rot_order_dict is in the right place.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f892032) 95.90% compared to head (0b3c04e) 96.03%.
Report is 4 commits behind head on dev.

Files Patch % Lines
src/build123d/geometry.py 96.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #420      +/-   ##
==========================================
+ Coverage   95.90%   96.03%   +0.13%     
==========================================
  Files          24       24              
  Lines        7321     7389      +68     
==========================================
+ Hits         7021     7096      +75     
+ Misses        300      293       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegenstein
Copy link
Collaborator Author

This should close #248 as well

@gumyr gumyr merged commit 671db72 into gumyr:dev Dec 5, 2023
12 checks passed
@gumyr
Copy link
Owner

gumyr commented Dec 5, 2023

This is a powerful addition - thanks for taking it on!

@jdegenstein jdegenstein deleted the RotOrder2 branch December 7, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants