Support multidimensional minus in algebra mode #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously algebra minus had a check that verified all arguments were of same dimension. However OCCT supports cutting a shape with shapes that are of equal OR larger dimension. This commit modifies the check to support larger dimensions and adds tests for all dimension variations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #465 +/- ##
==========================================
+ Coverage 96.04% 96.05% +0.01%
==========================================
Files 24 24
Lines 7427 7428 +1
==========================================
+ Hits 7133 7135 +2
+ Misses 294 293 -1 ☔ View full report in Codecov by Sentry. |
|
One note is you can in fact subtract one lower dimension, e.g 3d-2d or 2d-1d. The split operation (#427) is essentially subtracting 3d-2d with an extra step which separates the resulting parts based on their orientation relative to the splitting surfaces. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously algebra minus had a check that verified all arguments were of same dimension. However OCCT supports cutting a shape with shapes that are of equal OR larger dimension. This commit modifies the check to support larger dimensions and adds tests for all dimension variations.
Ref #446