Add Face.make_bezier_surface() #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegenstein
reviewed
Feb 16, 2024
src/build123d/topology.py
Outdated
| ) | ||
| if len(points) > 25 or len(points[0]) > 25: | ||
| raise ValueError("The maximum number of control points is 25") | ||
| if weights && (len(points) != len(weights) or |
There was a problem hiding this comment.
There is some invalid syntax here on 5721-, can you fix this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #552 +/- ##
==========================================
+ Coverage 96.24% 96.29% +0.05%
==========================================
Files 24 24
Lines 7746 7853 +107
==========================================
+ Hits 7455 7562 +107
Misses 291 291 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making superellipses and superellipsoids with build123d, I have found I get the best results using Bézier curves and surfaces to approximate the shapes. Bézier curves are already supported, but Bézier surfaces were not - at least not without dropping down to OCP.
Here's a sketchy patch based on the code i'm using to construct Bézier surfaces. I have not tried installing build123d from source so I have not properly tested this myself, but I think it's a plausible start.