Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created the PartCAD package for build123d examples. Added links. #610

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

openvmp
Copy link
Contributor

@openvmp openvmp commented Apr 15, 2024

No description provided.

@gumyr
Copy link
Owner

gumyr commented Apr 21, 2024

What is the partcad.yml file for? I understand what it does but do partcad users really want to build with any of the build123d examples? What is the expectation for support of this going forward, do all new examples need to be included in this file?

@openvmp
Copy link
Contributor Author

openvmp commented Apr 22, 2024

It makes the examples "packaged".

Once they are packaged, they become available (in the "/examples" folder) to anyone browsing the public repo of PartCAD packages (on PartCAD.org or through the PartCAD VSCode extension) so that people can see how to use build123d to create reusable packages.

I don't anticipate people actually using them in their designs. Though I can imagine someone using the T-slot or the din rail. Also you can start using PartCAD to render examples for the documentation purposes (both render the parts into images and the package itself into the documentation page). However your own rendering of examples already works. Though it might make sense to push that functionality to PartCAD to make it reusable.

In terms of support, you get no obligation to maintain it operational as I will reference a specific commit in your repo. If and only if you make a new revision that is functioning well and you want to publish it, we'll have to make a pull request in the PartCAD public repo to publish the new commit id.

@gumyr gumyr merged commit efaf894 into gumyr:dev Apr 22, 2024
@gumyr
Copy link
Owner

gumyr commented Apr 22, 2024

Merged. I don't know if I or others will remember to update the yml file so it's good to know that keeping this up-to-date isn't a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants