Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the manifest #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions examples/app-with-fix.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: goodmorning-deployment
labels:
app: goodmorning
spec:
replicas: 3
selector:
matchLabels:
app: goodmorning
template:
metadata:
labels:
app: goodmorning
spec:
# hostNetwork: true
# hostPID: true
securityContext:
# runAsUser: 0
fsGroup: 2000
containers:
- name: goodmorning
image: gunjan5/goodmorning:v1.0
securityContext:
# privileged: true
capabilities:
drop:
- all
# add:
# - NET_BIND_SERVICE
# - CAP_SYS_ADMIN
ports:
- containerPort: 8080
20 changes: 10 additions & 10 deletions examples/app.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,21 @@ spec:
labels:
app: goodmorning
spec:
hostNetwork: true
hostPID: true
# hostNetwork: true
# hostPID: true
securityContext:
runAsUser: 0
# runAsUser: 0
fsGroup: 2000
containers:
- name: goodmorning
image: gunjan5/goodmorning:v1.0
securityContext:
privileged: true
capabilities:
drop:
- all
add:
- NET_BIND_SERVICE
- CAP_SYS_ADMIN
# privileged: true
# capabilities:
# drop:
# - all
# add:
# - NET_BIND_SERVICE
# - CAP_SYS_ADMIN
ports:
- containerPort: 8080