fix: resolve bug in string/truncate

PR-URL: stdlib-js#2635 Closes: stdlib-js#2630 Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
gunjjoshi · Aug 21, 2024 · 88fff1e · 88fff1e
1 parent 9273a58
commit 88fff1e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/node_modules/@stdlib/string/truncate/lib/main.js b/lib/node_modules/@stdlib/string/truncate/lib/main.js
@@ -89,10 +89,10 @@ function truncate( str, len, ending ) {
 	ending = ending || '...';
 	endingLength = numGraphemeClusters( ending );
 	fromIndex = 0;
-	if ( len > numGraphemeClusters( str ) ) {
+	if ( len >= numGraphemeClusters( str ) ) {
 		return str;
 	}
-	if ( len - endingLength < 0 ) {
+	if ( len - endingLength <= 0 ) {
 		return ending.slice( 0, len );
 	}
 	nVisual = 0;

diff --git a/lib/node_modules/@stdlib/string/truncate/test/test.js b/lib/node_modules/@stdlib/string/truncate/test/test.js
@@ -145,6 +145,18 @@ tape( 'the function truncates a string to the specified length', function test(
 	actual = truncate( str, len );
 	t.strictEqual( actual, expected, 'returns expected value' );
 
+	str = 'beep boop';
+	len = 3;
+	expected = '...';
+	actual = truncate( str, len );
+	t.strictEqual( actual, expected, 'returns expected value' );
+
+	str = 'beep boop';
+	len = 9;
+	expected = 'beep boop';
+	actual = truncate( str, len );
+	t.strictEqual( actual, expected, 'returns expected value' );
+
 	str = '🐺 Wolf Brothers 🐺';
 	len = 6;
 	expected = '🐺 W...';