Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Minimum Spanning Tree (MST) algorithm. #127

Merged
merged 30 commits into from
Mar 23, 2022
Merged

Conversation

annielytical
Copy link
Member

No description provided.

@annielytical annielytical requested a review from neoblizz March 22, 2022 21:03
@annielytical annielytical removed the request for review from neoblizz March 22, 2022 21:05
Copy link
Member

@neoblizz neoblizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really well done! Great job @annielytical! We can do a few more performance passes after it is merged (I can handle some of that on my own while you move on to other things). The only main concern I have is that you're using an edge-frontier, which works because it is all index-based accessing, but is technically not supported in the back-end. Can you just create an issue for this? "Add complete support for edge-based frontiers", it will require minor changes but should become a bit more foolproof.

Rest of the stuff looks great. Most of my comments should be an easy fix.

examples/algorithms/mst/mst.cu Outdated Show resolved Hide resolved
examples/algorithms/mst/mst.cu Outdated Show resolved Hide resolved
examples/algorithms/mst/mst.cu Outdated Show resolved Hide resolved
include/gunrock/algorithms/mst.hxx Outdated Show resolved Hide resolved
include/gunrock/algorithms/mst.hxx Outdated Show resolved Hide resolved
include/gunrock/algorithms/mst.hxx Outdated Show resolved Hide resolved
include/gunrock/algorithms/mst.hxx Show resolved Hide resolved
include/gunrock/algorithms/mst.hxx Outdated Show resolved Hide resolved
@neoblizz neoblizz changed the title MST Minimum Spanning Tree (MST) algorithm. Mar 23, 2022
@neoblizz neoblizz added the 🍍 algorithms New or existing graph algorithms question. label Mar 23, 2022
@neoblizz neoblizz assigned annielytical and unassigned neoblizz Mar 23, 2022
@annielytical
Copy link
Member Author

Thank you! Everything mentioned above should be fixed in the latest commit.

The only thing I didn't change was filter::remove (I tested filter::bypass vs filter::remove and remove won).

@annielytical annielytical requested a review from neoblizz March 23, 2022 04:01
@neoblizz neoblizz merged commit a89fa24 into gunrock:dev Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍍 algorithms New or existing graph algorithms question.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minimum spanning tree (MST)
2 participants