This repository has been archived by the owner on Dec 22, 2022. It is now read-only.
[BUGFIX] Order of values passed to csc.set
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order of values passed to `csc.set` is incorrect. More descriptive names than `Aj`, `Ap`, `Ax` might be helpful here. Likewise, more descriptive names thatn `Ap`, `J`, `X`, `I` and `Aj` would be helpful in `graph/build/detail.hxx`. Any reason not to use the following? ``` row_offsets column_indices nonzero_values row_indices column_offsets ``` Or ... in my opinion even better because they're shorter, the same length 😄 and `nonzero_values` is redundant: ``` row_offsets col_indices values row_indices col_offsets ```
We can use these! If you wanna commit the name changes to this PR before we merge it, please go ahead! |
neoblizz
added
🐛 bug
|
Cleaned up names in this commit: #64 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order of values passed to
csc.setis incorrect.More descriptive names than
Aj,Ap,Axmight be helpful here.Likewise, more descriptive names thatn
Ap,J,X,IandAjwould be helpful ingraph/build/detail.hxx. Any reason not to use the following?Or ... in my opinion even better because they're shorter, the same length 😄 and
nonzero_valuesis redundant: