Allow Django app settings to override ChatterBot settings.

chatterbot/ext/django_chatterbot/apps.py

@@ -6,7 +6,3 @@ class DjangoChatterBotConfig(AppConfig):
     name = 'chatterbot.ext.django_chatterbot'
     label = 'django_chatterbot'
     verbose_name = 'Django ChatterBot'
-
-    def ready(self):
-        from chatterbot.ext.django_chatterbot import settings
-        settings.patch_all()

chatterbot/ext/django_chatterbot/settings.py

@@ -1,9 +1,15 @@
 from django.conf import settings
 
 
-CHATTERBOT = {
-    'NAME': 'ChatterBot'
+CHATTERBOT_SETTINGS = getattr(settings, 'CHATTERBOT', {})
+
+CHATTERBOT_DEFAULTS = {
+    'name': 'ChatterBot',
+    'storage_adapter': 'chatterbot.adapters.storage.DjangoStorageAdapter',
+    'input_adapter': 'chatterbot.adapters.input.VariableInputTypeAdapter',
+    'output_adapter': 'chatterbot.adapters.output.OutputFormatAdapter',
+    'output_format': 'json'
 }
 
-def patch_all():
-    setattr(settings, 'CHATTERBOT', CHATTERBOT)
+CHATTERBOT = CHATTERBOT_DEFAULTS.copy()
+CHATTERBOT.update(CHATTERBOT_SETTINGS)

chatterbot/ext/django_chatterbot/views.py

@@ -1,18 +1,12 @@
 from django.views.generic import View
 from django.http import JsonResponse
-from django.conf import settings
 from chatterbot import ChatBot
+from chatterbot.ext.django_chatterbot import settings
 
 
 class ChatterBotView(View):
 
-    chatterbot = ChatBot(
-        settings.CHATTERBOT['NAME'],
-        storage_adapter='chatterbot.adapters.storage.DjangoStorageAdapter',
-        input_adapter='chatterbot.adapters.input.VariableInputTypeAdapter',
-        output_adapter='chatterbot.adapters.output.OutputFormatAdapter',
-        output_format='json'
-    )
+    chatterbot = ChatBot(**settings.CHATTERBOT)
 
     def post(self, request, *args, **kwargs):
         input_statement = request.POST.get('text')
@@ -23,7 +17,8 @@ def post(self, request, *args, **kwargs):
 
     def get(self, request, *args, **kwargs):
         data = {
-            'detail': 'You should make a POST request to this endpoint.'
+            'detail': 'You should make a POST request to this endpoint.',
+            'name': self.chatterbot.name
         }
 
         # Return a method not allowed response

examples/django_app/example_app/settings.py

@@ -30,6 +30,12 @@
     'example_app',
 )
 
+# ChatterBot settings
+
+CHATTERBOT = {
+    'name': 'Django ChatterBot Example'
+}
+
 MIDDLEWARE_CLASSES = (
     'django.contrib.sessions.middleware.SessionMiddleware',
     'django.middleware.common.CommonMiddleware',

examples/django_app/tests/test_settings.py

@@ -0,0 +1,21 @@
+from django.test import TestCase
+from django.conf import settings
+
+
+class SettingsTestCase(TestCase):
+
+    def test_modified_settings(self):
+        with self.settings(CHATTERBOT={'name': 'Jim'}):
+            self.assertIn('name', settings.CHATTERBOT)
+            self.assertEqual('Jim', settings.CHATTERBOT['name'])
+
+    def test_name_setting(self):
+        from django.core.urlresolvers import reverse
+
+        api_url = reverse('chatterbot:chatterbot')
+        response = self.client.get(api_url)
+
+        self.assertEqual(response.status_code, 405)
+        self.assertIn('detail', response.json())
+        self.assertIn('name', response.json())
+        self.assertEqual('Django ChatterBot Example', response.json()['name'])