Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes in logic adapters & terminal example #112

Merged
merged 1 commit into from
Jan 25, 2016

Conversation

DarkmatterVale
Copy link
Collaborator

Just a couple of minor changes, including:

  1. Add additional logic adapters to the terminal example adding functionality
  2. Possible bug fix in evaluate_mathematically (not really sure, but this makes sure no bug will ever arise)
  3. Sometimes, the time logic adapter would find a statement similar to "what is 100 * 10?" as something it should process. By adding the additional piece of training data, the time adapter does not incorrectly process math statements as often

@gunthercox
Copy link
Owner

👍 Changes look good.

Also, I'm currently looking into #111. Should have some sort of feedback shortly.

gunthercox added a commit that referenced this pull request Jan 25, 2016
minor fixes in logic adapters & terminal example
@gunthercox gunthercox merged commit 73945d4 into gunthercox:master Jan 25, 2016
@DarkmatterVale
Copy link
Collaborator Author

Awesome! Thank you!

Also, on a side note, GCI ended today, so I hope to be able to spend some more time working on chatterbot now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants