Make sure that closest match adapter confidence returns value between 0 and 1 #113
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests ensure that the confidence value returned by the closest match adapter range between 0 and 1.
|
@DarkmatterVale I believe this corrects the issue observed in #111. Feel free to review and merge this pull request. |
|
@gunthercox Did it fix the problem for you? Can you now accurately get a response from the proper adapter? Regarding the issue with the database, we can discuss that in the issue and not this PR. |
|
This did correct the issue. |
|
Awesome, thank you for fixing it! I'm gonna go ahead and merge it in then. |
DarkmatterVale
added a commit
that referenced
this pull request
Jan 26, 2016
Make sure that closest match adapter confidence returns value between 0 and 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates and adds tests to ensure that the confidence value returned by the closest match adapter fall within the range between 0 and 1.