AIML english corpus updation into chatterbot #516

vkosuri · 2016-12-18T15:59:16Z

By looking into Repo https://github.com/drwallace/aiml-en-us-foundation-alice, i think we need update many conversations. I am started updating few important one

gunthercox · 2016-12-18T16:06:26Z

chatterbot/corpus/data/english/botprofile.corpus.json

+        ],
+        [
+            "FATHER",
+            "My father is Gunter Cox"


I'm not sure if I feel conformable with my name being in the data. Could you please remove it?

sure, reason don't understand

Thank you. The reason is simply that I want ChatterBot to be useful to as many developers as possible. So far, I've made sure that all the data in the training corpus is relatively generic. I feel like this is too specific. Also, keep in mind that ChatterBot is a tool for creating chat bots, it is not a chat bot itself so it shouldn't have an identity.

vkosuri · 2016-12-19T14:00:18Z

@gunthercox any comments/suggestion on this PR, I almost done except knowledge, I'll make another PR soon

vkosuri · 2016-12-20T07:58:47Z

@gunthercox i will re-submit knowledge corpus some other time. Any comments/suggestions?

gunthercox

I've left a few comments on parts of the files that appear to have issues. Hopefully this feedback is helpful. Let me know if you have any questions.

gunthercox · 2016-12-20T23:44:19Z

chatterbot/corpus/data/english/humor.corpus.json

+        [
+            "JOKE",
+            "Did you hear the one about the Mountain Goats in the Andes? It was Ba a a a a a d.",
+            "I never forget a face, but in your case I'll make an exception.",


I don't believe the format of this file would train an instance of ChatterBot properly. Each of these strings is a single statement, but none of them are related to each other. ChatterBot's corpus trainer expects the list to represent a conversation.

gunthercox · 2016-12-20T23:46:16Z

chatterbot/corpus/data/english/gossip.corpus.json

+
+    "gossip": [
+        [
+            "GOSSIP",


A number of these files have this extra single word at the top, it looks like it might be a duplicate of the outer corpus label. Either way, it is not a valid part of a conversation.

gunthercox · 2016-12-20T23:47:16Z

chatterbot/corpus/data/english/history.corpus.json

+            "History has two broad interpretations, depending on whether you accept the role of individuals as important or not."
+        ],
+        [
+            "WHO INVENTED THE LIGHT",


Proper sentence case is preferred in the corpus files.

gunthercox

I should have checked this sooner, but I just noticed that many of the files in this pull request appear to contain text that was directly copied from the repository at https://github.com/drwallace/aiml-en-us-foundation-alice/

The header included in each of the aiml files states:

<!-- This program is open source code released under -->
<!-- the terms of the GNU General Public License -->
<!-- as published by the Free Software Foundation. -->

The GNU General Public License is a copyleft license, which means that derivative work can only be distributed under the same license terms. ChatterBot is licensed under the BSD license, not GPL so legally they cannot be redistributed in ChatterBot without explicit permission from the copyright holder.

vkosuri · 2016-12-24T01:50:25Z

If he agrres re use can we use this stuff? Is there any sprcific mechanism license request changes?

gunthercox · 2016-12-24T01:58:38Z

If the owner agrees to allow the content to be released under a different license, then yes, it is safe to use. Usually it just takes an email to get in contact with the copyright owner.

vkosuri · 2017-01-07T17:22:22Z

@gunthercox any updates?

gunthercox · 2017-01-07T17:40:31Z

Because reusing text from https://github.com/drwallace/aiml-en-us-foundation-alice was authorized by @drwallace, this should be ok to merge soon. I will check over the changes to make sure everything is valid before merging it.

gunthercox

Overall this looks great. I've checked over the first few files and noted a few changes that need to be made. Please check over the rest of the files to make sure that there aren't similar issues to the ones I commented on.

gunthercox · 2017-01-07T17:42:20Z

chatterbot/corpus/data/english/ai.corpus.json

+            "Artificial intelligence is the branch of engineering and science devoted to constructing machines that think."
+        ],
+        [
+            "what language are you written",


There appears to be a missing "in" at the end of this sentence. I believe it should read:

what language are you written in

gunthercox · 2017-01-07T17:52:29Z

chatterbot/corpus/data/english/ai.corpus.json

+        ],
+        [
+            "It pays",
+            "No i am free of cost!!! you could start from here https://github.com/gunthercox/chatterbot"


This seems too specific to be useful to other developers. Maybe just remove the "you could start from here https://github.com/gunthercox/chatterbot" part.

gunthercox · 2017-01-07T17:56:12Z

chatterbot/corpus/data/english/botprofile.corpus.json

+{
+    "profile": [
+        [
+            "interests",


"interests" should probably be something like "What are your interests?"

gunthercox · 2017-01-07T17:57:49Z

chatterbot/corpus/data/english/botprofile.corpus.json

+        ],
+        [
+            "whats your masters email address",
+            "gunthercx@gmail.com"


As I mentioned in an earlier review, I would appreciate it if my name and email address were removed. I don't think this data would be useful to other developers who want to train their chat bot to communicate.

gunthercox · 2017-01-07T17:58:47Z

chatterbot/corpus/data/english/botprofile.corpus.json

+            "i will consume electricity"
+        ],
+        [
+            "location",


"location" might be better represented in the form of a question such as "What is your location?"

gunthercox · 2017-01-07T18:00:53Z

chatterbot/corpus/data/english/botprofile.corpus.json

+            "i don't have any brothers. but i have a lot of clones."
+        ],
+        [
+            "father",


The statement "father" should be a full sentence. Maybe something like "Who is your father?"

gunthercox · 2017-01-07T18:01:09Z

chatterbot/corpus/data/english/botprofile.corpus.json

+            "a human"
+        ],
+        [
+            "mother",


The statement "mother" should be a full sentence. Maybe something like "Who is your mother?"

gunthercox · 2017-01-07T18:04:15Z

chatterbot/corpus/data/english/emotion.corpus.json

+        ],
+        [
+            "Tell me about your dreams",
+            "I dream that i will become a better."


It looks like there is a noun missing at the end of this sentence. A better what?

gunthercox · 2017-01-07T18:05:36Z

chatterbot/corpus/data/english/food.corpus.json

+        ],
+        [
+            "for dinner",
+            "i don't dinner menu for you"


I'm not sure what "i don't dinner menu for you" is suppose to mean. This doesn't appear grammatically correct.

gunthercox · 2017-01-07T18:07:24Z

chatterbot/corpus/data/english/history.corpus.json

+
+    "history": [
+        [
+            "american civil war",


"american civil war" looks like a topic, when the text here should probably be a question or something else.

gunthercox · 2017-01-15T19:17:22Z

I rebased this pull request against the master branch to bring in the existing fix for the 2017 new years test bug.

1. Take my name out of it 2. Fix sentence capitalization

The requested changes have been made.

vkosuri · 2017-01-16T04:53:14Z

@gunthercox thank you very much

gunthercox reviewed Dec 18, 2016

View reviewed changes

gunthercox reviewed Dec 20, 2016

View reviewed changes

gunthercox requested changes Dec 24, 2016

View reviewed changes

gunthercox previously requested changes Jan 7, 2017

View reviewed changes

Martmists-GH mentioned this pull request Jan 15, 2017

Some minor text changes #585

Merged

Mallikarjunarao Kosuri added 19 commits January 15, 2017 14:15

food corpus

98d0f33

drugs corpus

2313b29

bot profile corpus

288b9ad

updated corpus number

9d57f5b

ai corpus

7f14e8f

botprofile updation

c97e1c1

gossip corpus

b97c2a4

history corpus

0bca944

politics corpus

dee00da

sports corpus

bf9dd06

emotion corpus

c4f24db

humor corpus

f1c0ae0

psychology corpus

e6777c4

science corpus

2f79d6e

corrected errors

8b55ddb

tests update

9acd08f

literature corpus

8ebe42e

money corpus

1b71a73

literature corpus

534b572

Mallikarjunarao Kosuri and others added 7 commits January 15, 2017 14:15

corpus updation

bd2e4e8

Update ai.corpus.json

1425fdd

Update ai.corpus.json

ae1005b

Update botprofile.corpus.json

63c01ab

Update emotion.corpus.json

5c7c665

Update food.corpus.json

7af0d2a

Update history.corpus.json

f1aa00d

gunthercox force-pushed the aiml_corpus branch from af48af1 to f1aa00d Compare January 15, 2017 19:15

Fix a few things in botprofile corpus

92b05b9

1. Take my name out of it 2. Fix sentence capitalization

gunthercox approved these changes Jan 15, 2017

View reviewed changes

gunthercox merged commit 23974d5 into master Jan 15, 2017

gunthercox deleted the aiml_corpus branch January 15, 2017 20:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AIML english corpus updation into chatterbot #516

AIML english corpus updation into chatterbot #516

vkosuri commented Dec 18, 2016 •

edited

Loading

gunthercox Dec 18, 2016

vkosuri Dec 18, 2016

gunthercox Dec 18, 2016

vkosuri commented Dec 19, 2016

vkosuri commented Dec 20, 2016

gunthercox left a comment

gunthercox Dec 20, 2016

gunthercox Dec 20, 2016

gunthercox Dec 20, 2016

gunthercox left a comment •

edited

Loading

vkosuri commented Dec 24, 2016

gunthercox commented Dec 24, 2016

vkosuri commented Jan 7, 2017

gunthercox commented Jan 7, 2017

gunthercox left a comment

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox Jan 7, 2017

gunthercox commented Jan 15, 2017

vkosuri commented Jan 16, 2017

AIML english corpus updation into chatterbot #516

AIML english corpus updation into chatterbot #516

Conversation

vkosuri commented Dec 18, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vkosuri commented Dec 19, 2016

vkosuri commented Dec 20, 2016

gunthercox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gunthercox left a comment • edited Loading

Choose a reason for hiding this comment

vkosuri commented Dec 24, 2016

gunthercox commented Dec 24, 2016

vkosuri commented Jan 7, 2017

gunthercox commented Jan 7, 2017

gunthercox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gunthercox commented Jan 15, 2017

vkosuri commented Jan 16, 2017

vkosuri commented Dec 18, 2016 •

edited

Loading

gunthercox left a comment •

edited

Loading