Sqlalchemy adapter #693

davizucon · 2017-04-19T04:31:58Z

This is the very first release of Sqlalchemy adapter, that have SQLite as default implementation, remains in alpha.

Notes:
- Tables may change (and will), so, save your training data. There no data migration (yet, not for alpha).
- Performance test not done yet.
- Tests using others databases not finished.
- Documentation on the way, any question, go to Create SQLite storage adapter #241 or chat on gitter. (faster with mention)

Thanks,
Davi

…sponse , and setting to lower case fuzz.ratio, sometimes the is not close enough to the right answer (my point of view).

… upstream

…o upstream

* upstream: Language fix and nltk fix to find correct library Fix test missing parameter. Add unit test to make sure that extra data is saved to the input statement. pass through extra data from the original input Add Gitter badge Fix broken link to "trainer classes on github" Renamed corpus readme files. Removed wiki link from readme. Fix arguments (+input_statement, statement_list) for most_frequent_response , and setting to lower case fuzz.ratio, sometimes the is not close enough to the right answer (my point of view). Update readme.md Update readme-es.md Update readme.pt.md Added Flask example link twitter adapter documentation

…sponse , and setting to lower case fuzz.ratio, sometimes the is not close enough to the right answer (my point of view).

assert method for None checks

minor typo

navyad/method wrappers

* upstream/master: (57 commits) Added views and settings to Django documentation. Update tests now that get_response returns an object. Remove output format setter from base test case. Removed language filter. Added filter test case for reperitive response filter. Added base test case for chatbots using Mongo DB Make it easier to extend the base test case. Added query tests. Add test case for new mongo_to_object method. Create filter documentation. Add filters to the Mongo DB example. Finished creating two simple filters. Remove base query restriction from get_random Add a method to convert Mongo DB results into statement objects. Converted mongo adapter to use query builder. Make query support for storage adapters optional. Create all the filters. Added base query support to mongo adapter. Added classes for filter objects. Avoid problems in str.format() with char accents ... # Conflicts: # .gitignore

…o sqlalchemy-adapter * 'master' of https://github.com/gunthercox/ChatterBot: Cast response.content to a string Fix unit tests for Django 1.8 Update Django settings documentation. Allow Django app settings to override ChatterBot settings. Add name attribute to ChatBot. Use a docstring for autodoc detection. Update training excption message. Update training parameter for docs and examples. Document ChatterBot parameters. Removed unused variable. Training class can now be set as a string passed to the ChatBot constructor. Raise an exception if an invalid tie breaking method is used. Change read the docs links from latest to stable. Update documentation settings. Add a favicon to docs. Resized logo background to be square. Correct static image paths in docs. Correct autodoc warnings. Added style for docs search header. Moved testing documentation from the readme to the docs.

davizucon · 2017-04-20T17:04:05Z

Finally !

vkosuri · 2017-04-24T00:16:36Z

chatterbot/storage/sqlalchemy_storage.py

+        # #        properties={
+        # #            'statement': relationship(Statement, backref='response')
+        # #        }, )
+        # mapper(Statement, self.statement)


I think you could remove these lines?

vkosuri · 2017-04-24T00:18:05Z

chatterbot/storage/sqlalchemy_storage.py

+
+        return results
+
+    # def filter(self, **kwargs):


I think you could remove these lines?

vkosuri · 2017-04-24T00:20:03Z

requirements.txt

@@ -3,3 +3,5 @@ jsondatabase>=0.1.7,<1.0.0
 nltk>=3.2.0,<4.0.0
 pymongo>=3.3.0,<4.0.0
 python-twitter>=3.0.0,<4.0.0
+textblob>=0.11.0,<0.12.0


Did you imported this package? I haven't seen

vkosuri · 2017-04-24T00:25:10Z

chatterbot/storage/__init__.py

@@ -2,3 +2,9 @@
 from .django_storage import DjangoStorageAdapter
 from .jsonfile import JsonFileStorageAdapter
 from .mongodb import MongoDatabaseAdapter
+
+# FIXME Better way manage import
+try:


I think these files are static and reside in same directory as long as they are. It's always a safe import.

vkosuri · 2017-04-24T00:30:09Z

chatterbot/storage/sqlalchemy_storage.py

+        return Response(text=self.text, **occ)
+
+
+# # relational table  TO REMOVE


I think you could remove these lines

vkosuri

Over all looks good, I think left over part is updating docs

…nd imports in requirements.txt, change imports in sqlalchemy and a little refactor.

davizucon · 2017-04-24T17:57:43Z

Hi @vkosuri , Indeed.

gunthercox

@davizucon This looks good. I'm going to pull it in as an undocumented beta-level feature. Much appreciation for all of your work getting this put together.

Requested changes have been made.

a-elhaddad · 2017-05-13T11:37:07Z

there is any way to see exemple using sqlalchemy ?

gunthercox · 2017-05-13T12:29:19Z

Hi @addelll, you can use this storage adapter the same way that the others are used.

For example,

chatbot = ChatBot(
    "My ChatterBot",
    storage_adapter="chatterbot.storage.SQLAlchemyDatabaseAdapter"
)

Is this what you are looking for as an example?

a-elhaddad · 2017-05-13T12:48:59Z

AttributeError: module 'chatterbot.storage' has no attribute 'SQLAlchemyDatabaseAdapter' ???

gunthercox · 2017-05-13T12:52:54Z

The reason you are seeing that message is likely because the current version of ChatterBot (0.6.0) doesn't contain the changes that were added in this pull request.

a-elhaddad · 2017-05-13T12:54:10Z

so any suggestions or i must copy directly from github ??

gunthercox · 2017-05-13T12:59:54Z

One possible way is to install directly from GitHub.

pip install git+git://github.com/gunthercox/ChatterBot.git@master

a-elhaddad · 2017-05-13T13:10:40Z

Thanks @gunthercox but some errors :
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such table: StatementTable

gunthercox · 2017-05-15T14:01:04Z

@addelll I believe you will need to set create=True when using this adapter for the first time.

davizucon · 2017-05-15T15:10:52Z

@gunthercox @addelll , Sorry, I'll update documentation, asap.

a-elhaddad · 2017-05-15T16:17:58Z

@gunthercox @davizucon thanks for the greate work , i need one full exemple using Sqlalchemy adapter because i have some errors after second release in heroku like
Arguments: ('columns text, text_search are not unique',)
I tried to fix that but ....

davizucon and others added 30 commits August 25, 2016 11:22

Avoid problems in str.format() with char accents

c25422c

Merge remote-tracking branch 'upstream/master'

92b3027

Encoding fix and few changes in dialogs.

bb368e6

Fix arguments (+input_statement, statement_list) for most_frequent_re…

a661284

…sponse , and setting to lower case fuzz.ratio, sometimes the is not close enough to the right answer (my point of view).

Fix arguments (+input_statement, statement_list) for most_frequent_re…

edb74f3

…sponse , and setting to lower case fuzz.ratio, sometimes the is not close enough to the right answer (my point of view).

Merge branch 'master' of https://github.com/davizucon/ChatterBot into…

7009e31

… upstream

Fix test missing parameter.

48bb0f4

Merge branch 'master' of https://github.com/gunthercox/ChatterBot int…

4c99ce3

…o upstream

Language fix and nltk fix to find correct library

706b081

Fix arguments (+input_statement, statement_list) for most_frequent_re…

a96a141

…sponse , and setting to lower case fuzz.ratio, sometimes the is not close enough to the right answer (my point of view).

Initial Version, not working yet

b3cf09c

Some work done, still need to implement other methods.

6b1a616

minor typ

cca2882

assert method for None checks

bdec3dd

super argument fix

427b42a

assertIsInstance for type check

a7999cb

Merge pull request #2 from navyad/navyad/tests

b0dbe22

assert method for None checks

Merge pull request #1 from navyad/navyad/sqlite

a6d00a9

minor typo

Some work done, still need to implement filter.

2ea136b

get_session is private

2f19f76

wrapper for filter

df91ecd

looping via map

b5b9d80

poi removed

d05541a

minor refactor

97b09a0

informatve variable name

3fa6ac7

Merge pull request #3 from navyad/navyad/method-wrappers

488e2da

navyad/method wrappers

merge changes from masters

d87b2d8

davizucon added 7 commits April 19, 2017 09:22

Fiz imports

5c8d7b6

Removed temp test class.

d0b68b8

fix import.

ba6dbb2

Rolback changes.

be8d2bb

Random database name for tests

401ba7a

Fix filter method, order of filters returning wrong values.

2e88087

Fix filter method, order of filters returning wrong values.

3af0b41

vkosuri reviewed Apr 24, 2017

View reviewed changes

vkosuri previously requested changes Apr 24, 2017

View reviewed changes

davizucon added 2 commits April 24, 2017 11:04

Changes by code review: Clean up, removed unnecessary code comments a…

1c01393

…nd imports in requirements.txt, change imports in sqlalchemy and a little refactor.

Fixing import, not depend on SQLAlchemy.

6ffb847

gunthercox approved these changes Apr 29, 2017

View reviewed changes

gunthercox merged commit 6ffb847 into gunthercox:master Apr 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sqlalchemy adapter #693

Sqlalchemy adapter #693

davizucon commented Apr 19, 2017

davizucon commented Apr 20, 2017

vkosuri Apr 24, 2017

vkosuri Apr 24, 2017

vkosuri Apr 24, 2017

vkosuri Apr 24, 2017

vkosuri Apr 24, 2017

vkosuri left a comment

davizucon commented Apr 24, 2017

gunthercox left a comment •

edited

Loading

a-elhaddad commented May 13, 2017

gunthercox commented May 13, 2017

a-elhaddad commented May 13, 2017

gunthercox commented May 13, 2017

a-elhaddad commented May 13, 2017

gunthercox commented May 13, 2017

a-elhaddad commented May 13, 2017 •

edited

Loading

gunthercox commented May 15, 2017

davizucon commented May 15, 2017

a-elhaddad commented May 15, 2017

		return Response(text=self.text, **occ)


		# # relational table TO REMOVE

Sqlalchemy adapter #693

Sqlalchemy adapter #693

Conversation

davizucon commented Apr 19, 2017

davizucon commented Apr 20, 2017

vkosuri Apr 24, 2017

Choose a reason for hiding this comment

vkosuri Apr 24, 2017

Choose a reason for hiding this comment

vkosuri Apr 24, 2017

Choose a reason for hiding this comment

vkosuri Apr 24, 2017

Choose a reason for hiding this comment

vkosuri Apr 24, 2017

Choose a reason for hiding this comment

vkosuri left a comment

Choose a reason for hiding this comment

davizucon commented Apr 24, 2017

gunthercox left a comment • edited Loading

Choose a reason for hiding this comment

a-elhaddad commented May 13, 2017

gunthercox commented May 13, 2017

a-elhaddad commented May 13, 2017

gunthercox commented May 13, 2017

a-elhaddad commented May 13, 2017

gunthercox commented May 13, 2017

a-elhaddad commented May 13, 2017 • edited Loading

gunthercox commented May 15, 2017

davizucon commented May 15, 2017

a-elhaddad commented May 15, 2017

gunthercox left a comment •

edited

Loading

a-elhaddad commented May 13, 2017 •

edited

Loading