Prevent statements that are not in response to a known statement from being passed to the logic adapter. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statement that lists them in the in_response_to field. This change prevents random responses from being returned when the closest match to the input statement is not a response of any known statement.
gunthercox
added a commit
that referenced
this pull request
Nov 24, 2015
Prevent statements that are not in response to a known statement from being passed to the logic adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects an issue for cases where no statements exist that are in response to the closest matching statement. This previously resulted in a case where a matching response could not be found and caused a random response to be returned.
Closes #71
Closes #72