Replace ChatterBot's "sessions" with "Conversations" #828
Conversation
gunthercox
force-pushed
the
conversations
branch
2 times, most recently
from
16d5d04 to
21aaecd
Compare
gunthercox
force-pushed
the
conversations
branch
from
8eede4f to
fd87dd6
Compare
| Returns the latest response in a conversation if it exists. | ||
| Returns None if a matching conversation cannot be found. | ||
| """ | ||
| from django.apps import apps |
There was a problem hiding this comment.
from django.apps import apps are many places, instead can we import one time on top of the page?
There was a problem hiding this comment.
Importing third party packages at the top of a file sometimes causes unexpected errors depending on how users install ChatterBot. The best way (that I have found) to avoid this is to protect the imports by placing them inside of a method as this prevents them from being imported when the file is loaded. I'm actually not certain why some people encounter the import errors but it seems that it may be the result of less conventional (but still somewhat valid) installation methods such as installing directly through setup.py commands.
gunthercox
force-pushed
the
conversations
branch
3 times, most recently
from
bdcee61 to
927d501
Compare
| migrations.DeleteModel( | ||
| name='Phrase', | ||
| ), | ||
| ] |
There was a problem hiding this comment.
- Remember to squash and re-generate these migrations.
gunthercox
force-pushed
the
conversations
branch
2 times, most recently
from
05c9618 to
3473bab
Compare
|
💯 |
gunthercox
force-pushed
the
conversations
branch
from
f1ab80b to
e67735b
Compare
This pull request is currently a work-in-progress.
For #811 to create consistent sessions that are tracked in the database instead of in memory.
Closes #513 by replacing it.