Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CharField to TextField #923

Closed
wants to merge 2 commits into from
Closed

Conversation

vkosuri
Copy link
Collaborator

@vkosuri vkosuri commented Aug 11, 2017

Copy link
Owner

@gunthercox gunthercox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkosuri Thank you, these changes look good. The only thing that needs to be updated is that Django is going to need migrations for this change.

@vkosuri
Copy link
Collaborator Author

vkosuri commented Aug 12, 2017

@gunthercox I try to make migrations on django_chatterbot it was saying no changes found. I tried like this. Any tips how do migration on django_chatterbot?

(env)vkosuri@vm-vkosuri:~/ChatterBot$ python examples/django_app/manage.py migrate django_chatterbot
Operations to perform:
  Apply all migrations: django_chatterbot
Running migrations:
  No migrations to apply.
(env)vkosuri@vm-vkosuri:~/ChatterBot$ python examples/django_app/manage.py makemigrations django_chatterbot
No changes detected in app 'django_chatterbot'

@gunthercox
Copy link
Owner

I'll look into this and see if I can recreate the issue. I'll let you know what I have to do to get them to generate.

@vkosuri vkosuri closed this Aug 15, 2017
@vkosuri vkosuri deleted the long_type_char branch August 15, 2017 03:58
@vkosuri
Copy link
Collaborator Author

vkosuri commented Aug 15, 2017

This PR will solve this problem gunthercox/chatterbot-corpus#36

@vkosuri
Copy link
Collaborator Author

vkosuri commented Aug 15, 2017

@gunthercox Thanks fix this issue, could you please let me know how to generate django_chatterbot migrations?

@gunthercox
Copy link
Owner

These are the steps. They work but I wish I had easier ones.

  1. cd ChatterBot
  2. pip install . --upgrade
  3. cd examples/django_app/
  4. python manage.py makemigrations
  5. Navigate to the Python package install directory and cut and paste the new migration into the migrations directory of your local project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants