Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature lumaris rgb tunable white #177

Merged

Conversation

RBaragona
Copy link
Contributor

Add support for a new LEAP light device type to enable control of Lumaris RGB + Tunable White.

@RBaragona
Copy link
Contributor Author

@mdonoughe or @bdraco , anything you'd like to see in order to approve/merge this? I tested this with a HWQSX system.

@eclair4151
Copy link
Contributor

You'll need to add some tests for sure, start by defining a new device/zone/etc inside the test response jsons:
https://github.com/gurumitts/pylutron-caseta/tree/dev/tests/responses/hwqsx

And then add tests in test_smartbridge to confirm the request and response and formatted as expected
https://github.com/gurumitts/pylutron-caseta/blob/dev/tests/test_smartbridge.py

See test_qsx_set_ketra_color for a similar example.

mdonoughe and bdraco, let me know if you want me to test as well, happy to throw a fake tunable RGB on my QSX system with lutron designer and confirm I can control it via the library.

CHANGELOG.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/pylutron_caseta/smartbridge.py Outdated Show resolved Hide resolved
src/pylutron_caseta/__init__.py Outdated Show resolved Hide resolved
src/pylutron_caseta/smartbridge.py Outdated Show resolved Hide resolved
@RBaragona RBaragona force-pushed the new-feature-Lumaris-RGB-Tunable-White branch from a04813b to 01947af Compare January 3, 2025 17:15
}
],
"DeviceClass": {
"HexadecimalEncoding": "61a0101"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eclair4151 I'm not sure how to find the device class, but I also do not see it used, so do not believe this impacts function/testing.

@RBaragona
Copy link
Contributor Author

@mdonoughe I believe I have addressed all of your comments. Please let me know if anything else is needed?

@eclair4151 , I have added tests as you suggested.

I believe this should be ready to merge.

@eclair4151
Copy link
Contributor

Looks good to me. I don't have one of those devices to test, but I assume you tried it out on yours.
I also just raised a quick PR to add a new tilt device type for wood blinds, so hopefully we can get these both merged in, and then make a .23 release

@mdonoughe mdonoughe merged commit efde230 into gurumitts:dev Jan 6, 2025
6 checks passed
@RBaragona RBaragona deleted the new-feature-Lumaris-RGB-Tunable-White branch January 6, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants