-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature lumaris rgb tunable white #177
New feature lumaris rgb tunable white #177
Conversation
@mdonoughe or @bdraco , anything you'd like to see in order to approve/merge this? I tested this with a HWQSX system. |
You'll need to add some tests for sure, start by defining a new device/zone/etc inside the test response jsons: And then add tests in test_smartbridge to confirm the request and response and formatted as expected See test_qsx_set_ketra_color for a similar example. mdonoughe and bdraco, let me know if you want me to test as well, happy to throw a fake tunable RGB on my QSX system with lutron designer and confirm I can control it via the library. |
a04813b
to
01947af
Compare
} | ||
], | ||
"DeviceClass": { | ||
"HexadecimalEncoding": "61a0101" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eclair4151 I'm not sure how to find the device class, but I also do not see it used, so do not believe this impacts function/testing.
@mdonoughe I believe I have addressed all of your comments. Please let me know if anything else is needed? @eclair4151 , I have added tests as you suggested. I believe this should be ready to merge. |
Looks good to me. I don't have one of those devices to test, but I assume you tried it out on yours. |
Add support for a new LEAP light device type to enable control of Lumaris RGB + Tunable White.