Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resolved typeRoots into the discarded includes to maintain global types. #22

Closed
wants to merge 1 commit into from
Closed

Add resolved typeRoots into the discarded includes to maintain global types. #22

wants to merge 1 commit into from

Commits on Nov 30, 2021

  1. feat: add resolved typeRoots into the include 

    This is an idea to fix gustavopch#20.

Instead of discarding all includes, which seems to discard required global `.d.ts` files, can we use the `typeRoots` a config may have setup instead?

I don't think this quite hits the mark however:
 - Does everyone use `typeRoots` in this manner?  I do not know.
 - Likely will not work for a monorepo with nested tsconfig as files are resolved to the root.
 - Often `typeRoots` will import a fair bit, this could still include a large % of your codebase.  My `typeRoots` includes `node_modules/@types`–this may defeat the purpose gustavopch#18 set out to resolve.
    @kylorhall
    kylorhall committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    c27e4ec View commit details
    Browse the repository at this point in the history