Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sourcemapping regex #218

Merged
merged 2 commits into from
Nov 4, 2021
Merged

Fix sourcemapping regex #218

merged 2 commits into from
Nov 4, 2021

Conversation

guybedford
Copy link
Owner

@guybedford guybedford commented Nov 3, 2021 •
edited
Loading

Resolves #217.

//cc @hronro

@guybedford guybedford mentioned this pull request Nov 3, 2021
Closed
@hronro
Copy link

hronro commented Nov 4, 2021

CleanShot 2021-11-04 at 11 31 05@2x

It's really hard to be done properly with simple regex replacement.

@guybedford
Copy link
Owner Author

Because they have to be at the end of the source it is actually quite well defined.

I've pushed up a new fix, let me know if that can work for you?

@hronro
Copy link

hronro commented Nov 4, 2021 •
edited
Loading

Cool, the new fix works for me.

@guybedford guybedford changed the title attempted sourcemapping fix Fix sourcemapping regex Nov 4, 2021
@guybedford guybedford merged commit 1fc26eb into main Nov 4, 2021
@guybedford guybedford deleted the sourcemapping branch November 4, 2021 16:33
@guybedford
Copy link
Owner Author

Thanks for confirming, I will include in the next release in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sourceMappingURL and sourceURL rewriting breaks my apps
2 participants
@guybedford @hronro