Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onpolyfill note default #237

Merged
merged 3 commits into from
Dec 15, 2021
Merged

feat: onpolyfill note default #237

merged 3 commits into from
Dec 15, 2021

Conversation

guybedford
Copy link
Owner

This updates the onpolyfill hook to apply when first executing polyfilled code instead of just on init, so when there is a real native code path that failed that the polyfill is kicking in to polyfill.

Then, the default hook contains a console.info message noting that the native error which will be present can be ignored.

Here's how that looks in Firefox:

image

Hopefully this will help avoid any production confusions.

@guybedford
Copy link
Owner Author

I've updated the note to try and be clearer:

image

@guybedford guybedford merged commit 5b8033a into main Dec 15, 2021
@guybedford guybedford deleted the polyfill-note branch December 15, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant