Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resolve.js to throm error on non hierarchical base scheme #393

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Update resolve.js to throm error on non hierarchical base scheme #393

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a621c43
Update resolve.js to throm error on non hierarchical base scheme
jogibear9988 Sep 13, 2023
acf9211
Fix Type of error
jogibear9988 Sep 13, 2023
2e11e84
Update resolve.js - Remove unneeded text
jogibear9988 Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ export function resolveIfNotPlainOrUrl (relUrl, parentUrl) {
relUrl.length === 1 && (relUrl += '/')) ||
relUrl[0] === '/') {
const parentProtocol = parentUrl.slice(0, parentUrl.indexOf(':') + 1);
if (parentProtocol === 'blob:') {
throw new Error(`Uncaught (in promise) TypeError: Failed to resolve module specifier "${relUrl}". Invalid relative url or base scheme isn't hierarchical.`);
guybedford marked this conversation as resolved.
Show resolved Hide resolved
}
// Disabled, but these cases will give inconsistent results for deep backtracking
//if (parentUrl[parentProtocol.length] !== '/')
// throw new Error('Cannot resolve');
Expand Down