New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the correct type of Parameter static option #113

Closed

Konafets opened this issue Oct 21, 2016 · 0 comments

Contributor

Konafets commented Oct 21, 2016 •

edited

Loading

The service description knows a static option. From the header doc:

static: (bool) Set to true to specify that the parameter value cannot be changed from the default.

However, in the UnitTests the static option gets a string static! assigned.

Proposal: If static is boolean, we should change the test and also change the method name from getStatic() to isStatic().

The service description definition clearly defines static as type of boolean.

The text was updated successfully, but these errors were encountered:

Konafets added a commit to Konafets/guzzle-services that referenced this issue


          Correct the type of var $static from string to boolean

445e071

The service description definition at http://guzzle3.readthedocs.io/_downloads/guzzle-schema-1.0.json defines the option `static` as boolean. Until now the option was handled internally as a string. This patch change the internal usage to boolean.

Closes: guzzle#113

Konafets closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment