Allow to fix validation for parameters with a format #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind, I've been able to find a fix :). |
|
Can you rewrite the topic of the PR and add a description about the change? |
bakura10
changed the title
|
Sure. Fixed! :) |
|
Thank you for your contribution! |
|
Thanks a lot ! Possible to tag ? :p |
|
Sorry, I dont like to release any tiny change into a new version. You can require the "dev-develop" branch in your composer.json. |
|
Sorry, I don’t like using untagged version in production :p.
I understand the rationale but I personally now tagged new version for every little bug fix, and it makes things much easier to handle (more smaller release so way easier to identify any regression, less issues as bug are fixed immediately…). I would strongly suggest you to go that way :). But you handle the package, do as you prefer :).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
Some parameters may have a given type (example: string) in conjunction of a format (such as "date-time").
Currently, passing a DateTime for instance to such fields throw a validation error, because the format is done after validating it. As such conversion change the type of the value (DateTime => string), this PR ensures that this conversion is done before validating.