Gracefully handle null return from $this->getConfig('defaults') #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an "unsupported operand types" error.
|
👍 |
|
When can we merge this? |
|
👍 Although I've created a pull request which might be better as returning a array for all missing keys would be misleading as it should really only do this for defaults which can be set at the point of constructing the client |
|
@mtdowling Can this, #96, or guzzle/command#26 be reviewed and merged please? |
mtdowling
added a commit
that referenced
this pull request
Nov 2, 2015
Gracefully handle null return from $this->getConfig('defaults')
|
Thanks @mtdowling. How does your release schedule work? Is it likely that we will see a new point release with this and other recent fixes? We're getting to the end of our sprint (Friday) and this is one of the last tickets left, so I'm just gauging whether to wait for a point release, or if we should update our composer.json to point to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an "unsupported operand types" error.
Either this or guzzle/command#26 will resolve the issue, I'm leaving it up to the upstream authors to decide which approach is more appropriate since the return type of
getConfig()is a design decision.