Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix description for get request example #87

Closed
wants to merge 1 commit into from
Closed

fix description for get request example #87

wants to merge 1 commit into from

Conversation

snoek09
Copy link

@snoek09 snoek09 commented May 25, 2015

GET request used in example should be http://httpbin.org/get?foo=bar

@snoek09 snoek09 closed this Jan 6, 2016
@snoek09 snoek09 reopened this May 20, 2016
@Konafets
Copy link
Contributor

Please explain why this should be changed?

@snoek09
Copy link
Author

snoek09 commented Oct 21, 2016

The current example doesn't work:

PHP Fatal error:  Uncaught GuzzleHttp\Exception\ClientException: Client error response [url] http://httpbin.org/get/bar [status code] 404 [reason phrase] NOT FOUND in /guzzle-services/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:89

@@ -16,15 +16,11 @@ Provides an implementation of the Guzzle Command library that uses Guzzle servic
'operations' => [
'testing' => [
'httpMethod' => 'GET',
'uri' => '/get/{foo}',
'uri' => 'get',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the line to 'uri' => '/get{?foo}',

'location' => 'uri'
],
'bar' => [
'type' => 'string',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this code here.

@snoek09 snoek09 mentioned this pull request Oct 21, 2016
@snoek09
Copy link
Author

snoek09 commented Oct 21, 2016

Thanks @Konafets, I've created a new PR for this (as I deleted my fork for this PR): #115

@snoek09 snoek09 closed this Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants