Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added P.string.length #257

Merged
merged 5 commits into from
Jun 12, 2024
Merged

feat: Added P.string.length #257

merged 5 commits into from
Jun 12, 2024

Conversation

JUSTIVE
Copy link
Contributor

@JUSTIVE JUSTIVE commented Jun 5, 2024

resolves #256 .

@JUSTIVE JUSTIVE force-pushed the feature-string-length branch from a382cae to 8527727 Compare June 5, 2024 06:28
gvergnaud
gvergnaud reviewed Jun 7, 2024
View reviewed changes
Copy link
Owner

@gvergnaud gvergnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! a few minor comments

src/types/Pattern.ts Outdated Show resolved Hide resolved
src/types/Pattern.ts Outdated Show resolved Hide resolved
@JUSTIVE
Copy link
Contributor Author

JUSTIVE commented Jun 7, 2024 •
edited
Loading

thanks for the reply! just applied all of your comments

@gvergnaud gvergnaud merged commit 1a568a5 into gvergnaud:main Jun 12, 2024
@gvergnaud
Copy link
Owner

Merged and published as 5.2.0

@lkeff lkeff mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvergnaud gvergnaud gvergnaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P.string.length
2 participants
@JUSTIVE @gvergnaud