Export Pattern types in package.json #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvergnaud
reviewed
Oct 3, 2024
package.json
Outdated
Comment on lines
20
to
27
| "./types": { | ||
| "require": { | ||
| "types": "./dist/types/Pattern.d.cts" | ||
| }, | ||
| "import": { | ||
| "types": "./dist/types/Pattern.d.ts" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Could you create a types/index.ts file that exports the types we need from Pattern.ts? This should make it easier to export type from other files if necessary in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #291
Changes
Export
Pattern.d.tsin the package.json to solve the issue. They are now available atts-pattern/types.QA
Doing the same changes from this PR in this playground fixes the TS error