Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use consistent approx name #14

Merged
merged 1 commit into from
May 14, 2024
Merged

use consistent approx name #14

merged 1 commit into from
May 14, 2024

Conversation

WuShichao
Copy link
Collaborator

I found in your last PR that there are inconsistent names.

@WuShichao
Copy link
Collaborator Author

@mj-will

@WuShichao WuShichao added the bug Something isn't working label May 14, 2024
@WuShichao WuShichao merged commit c6c8ba1 into main May 14, 2024
3 checks passed
@mj-will
Copy link
Contributor

mj-will commented May 15, 2024

Thanks @WuShichao I think this sneaked in the original MR and I didn't spot it. I'll open a PR with a test for this

@WuShichao WuShichao deleted the rename_approx branch May 15, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WuShichao @mj-will