Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xml foreground into multiifo workflow #3284

Merged
merged 1 commit into from
May 20, 2020

Conversation

GarethCabournDavies
Copy link
Contributor

Create XML files needed to allow gracedb uploads from the offline workflow

extension='.xml', tags=["xmlall"])
fore_xmlloudest = wf.make_foreground_table(workflow, combined_bg_file,
hdfbank, rdir['open_box_result'], singles=insps,
extension='.xml', tags=["xmlloudest"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just make sure that any relevant config files contain the options related to these tags!

Copy link
Contributor

@spxiwh spxiwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But you'll need to rebase once #3285 is merged as Travis is currently failing.

@GarethCabournDavies GarethCabournDavies merged commit 671646c into gwastro:master May 20, 2020
lenona pushed a commit to lenona/pycbc that referenced this pull request Sep 14, 2020
OliverEdy pushed a commit to OliverEdy/pycbc that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants