-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid nan values in network volume term - MASTER VERSION #5050
Open
GarethCabournDavies
wants to merge
12
commits into
gwastro:master
Choose a base branch
from
GarethCabournDavies:stat_nan_sigma_master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Avoid nan values in network volume term - MASTER VERSION #5050
GarethCabournDavies
wants to merge
12
commits into
gwastro:master
from
GarethCabournDavies:stat_nan_sigma_master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tdent
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look OK based on the related Live branch PR.
baf72a5
to
7d23c8b
Compare
tdent
reviewed
Feb 20, 2025
Co-authored-by: Thomas Dent <thomas.dent@usc.es>
tdent
reviewed
Feb 20, 2025
Minor polishing on comments, but looks OK to me assuming tests pass. |
Co-authored-by: Thomas Dent <thomas.dent@usc.es>
tdent
approved these changes
Feb 20, 2025
We want np -> numpy in stat.py 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing live with the new ranking statistic, we were getting a lot of weird FARs - this is due to getting stat values which were nan, and these were considered louder than everything else in the count_n_louder.
Standard information about the request
This is a bug fix
This change affects the live search, and touches code of the offline search, but shouldn't affect anything
This change changes scientific output
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Contents
We combat this problem in three ways, which should prevent it occurring as much as possible:
-np.inf
. This shouldn't happen due to the protections aboveDownsides of this approach:
Links to any issues or associated PRs
#5049
Testing performed
None yet